mosn / layotto

A fast and efficient cloud native application runtime
http://mosn.io/layotto/
Apache License 2.0
817 stars 168 forks source link

bug(ci): deadlink checker didn't find the wrong url in sidebar #799

Open seeflood opened 1 year ago

seeflood commented 1 year ago

What happened: @wenxuwan found that the link in the sidebar is wrong, see https://mosn.io/layotto/#/zh/design/oss/oss-api-design image

The problem is that our deadlink checker didn't find it :( The checker runs successfully without noticing this link: https://github.com/mosn/layotto/actions/workflows/dead-link-checker.yaml image

What you expected to happen: deadlink checker should find out the wrong urls

How to reproduce it (as minimally and precisely as possible): open https://mosn.io/layotto/#/zh/design/oss/oss-api-design

Anything else we need to know?:

seeflood commented 1 year ago

cc @Xunzhuo

seeflood commented 1 year ago

I found that curl -w %{http_code} https://mosn.io/layotto/#/zh/design/oss/oss-api-design returns 200, not 404 So it's docsify's problem, not our deadlink checker's problem. :( This issue is not a high priority

rayowang commented 1 year ago

This looks like a routing problem with webserver configuration.

seeflood commented 1 year ago

Yes, but I don't know how to configure the docsify server to fix this issue 😢