Open muyuan0 opened 1 year ago
For example, even if there is an error return, the final returned error is still always nil: https://github.com/mosn/mosn/blob/21cfb09295bcd44348e8b93ee7b10676e5ed532b/pkg/stream/http2/var.go#L73-L76
And the error handling code in the pkg/stream/http/var.go file is different from pkg/stream/http2/var.go in the cookie getter: https://github.com/mosn/mosn/blob/21cfb09295bcd44348e8b93ee7b10676e5ed532b/pkg/stream/http/var.go#L162-L167 https://github.com/mosn/mosn/blob/21cfb09295bcd44348e8b93ee7b10676e5ed532b/pkg/stream/http2/var.go#L109-L112
One returns an error but the other doesn't.
Sorry, my oversight, this problem should have been solved in the previous version
https://github.com/mosn/mosn/pull/2174
Your question
For example, even if there is an error return, the final returned error is still always nil: https://github.com/mosn/mosn/blob/21cfb09295bcd44348e8b93ee7b10676e5ed532b/pkg/stream/http2/var.go#L73-L76
And the error handling code in the pkg/stream/http/var.go file is different from pkg/stream/http2/var.go in the cookie getter: https://github.com/mosn/mosn/blob/21cfb09295bcd44348e8b93ee7b10676e5ed532b/pkg/stream/http/var.go#L162-L167 https://github.com/mosn/mosn/blob/21cfb09295bcd44348e8b93ee7b10676e5ed532b/pkg/stream/http2/var.go#L109-L112
One returns an error but the other doesn't.
Environment