search

mosn / mosn

The Cloud-Native Network Proxy Platform
https://mosn.io
Apache License 2.0
4.43k stars 797 forks source link

'make image' write 'mosnd' into 'sbin' instead put 'mosnd' under 'sbin' #914

Open Vstural opened 4 years ago

Vstural commented 4 years ago

Describe the bug

according to dockerfile, it expect add $MOSN_PREFIX/sbin into path and run 'mosnd' as proxy but it write 'sbin' as file

Expected behavior

Actual behavior

PS C:\Users\Administrator> docker exec -it mosn bash
[root@a75bc4680c04 pip-18.0]# pwd
/tmp/pip-18.0
[root@a75bc4680c04 pip-18.0]# ls
AUTHORS.txt  MANIFEST.in  PKG-INFO    build  docs            setup.cfg  src
LICENSE.txt  NEWS.rst     README.rst  dist   pyproject.toml  setup.py
[root@a75bc4680c04 pip-18.0]# cd /home/admin/mosn/
[root@a75bc4680c04 mosn]# ls
conf  logs  sbin
[root@a75bc4680c04 mosn]# stat sbin
  File: 'sbin'
  Size: 39199038        Blocks: 76568      IO Block: 4096   regular file
Device: 801h/2049d      Inode: 2495117     Links: 1
Access: (0755/-rwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2019-12-19 09:27:38.000000000 +0000
Modify: 2019-12-19 09:27:38.000000000 +0000
Change: 2019-12-19 09:28:31.865563200 +0000
 Birth: -
[root@a75bc4680c04 mosn]# ./sbin
NAME:
   mosn - MOSN is modular observable smart netstub.

USAGE:
   sbin [global options] command [command options] [arguments...]

VERSION:
   0.8.1(e3e11830)

COMMANDS:
     start    start mosn proxy
     stop     stop mosn proxy
     reload   reconfiguration
     help, h  Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --help, -h     show help
   --version, -v  print the version

COPYRIGHT:
   (c) 2019 Ant Financial
[root@a75bc4680c04 mosn]# pwd
/home/admin/mosn
[root@a75bc4680c04 mosn]# ls
conf  logs  sbin
[root@a75bc4680c04 mosn]#

Steps to reproduce

$ make image
$ docker run --name mosn 3bca612bab06
$ docker exec -it mosn bash

Minimal yet complete reproducer code (or GitHub URL to code)

Environment

windows10

PS C:\Users\Administrator> docker -v
Docker version 19.03.5, build 633a0ea

branch master,hash e3e11830cfca1bcae5db7bbbbde24d5d9c247d97 2019/11/25 20:15:49

nejisama commented 4 years ago

make image is just a example image. the sbin is out of date. we will remove it