search

mosquito-cr / mosquito

A background task runner for crystal applications supporting periodic (CRON) and manually queued jobs
MIT License
227 stars 24 forks source link

Ensure only Int numbers are passed to delete and cast to Int64. #136

Closed jwoertink closed 5 months ago

jwoertink commented 5 months ago

Fixes #135

Running make test with the -Dno_number_autocast passes with this change.

I did notice that passing an Int32 was "soft" deprecated

https://github.com/mosquito-cr/mosquito/blob/0107dba08b18670832423f8e8d725b9b4f35db81/src/mosquito/redis_backend.cr#L83-L88

So I can turn this in to Int64 directly, but in doing that, there was several spots that had to be changed, so I wasn't sure if this is something that is wanting to be done just yet or not.

robacarp commented 5 months ago

That soft deprecation period is certainly finished and can be removed, but that need not be here.