Closed watzon closed 4 years ago
I was actually thinking about using Habitat, would you be opposed to that? I can update the PR later.
@watzon absolutely! That would be a fantastic upgrade. :)
Ok cool, I'll see what I can do :)
Are there other configuration options that it would make sense to have there besides the redis url?
@watzon this completely dropped off my radar. One out of scope addition that needs to be cleaned up and I'd be happy to merge.
Awesome, thanks 😊
Idk how you feel about this. Personally I feel like, since so many things are being done at the class level rather than the instance level anyway (i.e. using
Class.instance
everywhere), it would make sense to have aConfig
module which holds configuration options. I'd be happy to add such a thing and update this PR, but for now I've just added a class propertyconnection_url
to theRedis
class which defaults toENV["REDIS_URL"]
.The benefit of this approach is that people can set their own environment variable if they want, or load the configuration option in another way. For example:
This would close #3