setup.py breaks support for py3.6

mosquito / aio-pika

AMQP 0.9 client designed for asyncio and humans.

https://aio-pika.readthedocs.org/

Apache License 2.0

1.18k stars 186 forks source link

setup.py breaks support for py3.6 #441

Open Dunes opened 2 years ago

Dunes commented 2 years ago

Documentation states that python3.6 is supported, but setup.py states python_requires=">3.6, <4". Correct format for supporting python3.6 should be python_requires=">=3.6, <4"

See https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#python-requires

Currently this has borked a poetry-based library that supports py3.6 and wants to upgrade to aio_pika 7.

thorlock12 commented 2 years ago

@mosquito I see this was fixed and then merged in https://github.com/mosquito/aio-pika/commit/9a98064931db909b5de3546f23335c8ac2b50aca but then undone in https://github.com/mosquito/aio-pika/commit/a867bb63988b382cb5aef5107234e414abd0a4b6

Was this intentional?