Closed viiand closed 2 years ago
Hey there. I found an issue with the 8 version. client_properties cannot be passed to the aio_pika.connect_robust/connect anymore.
The problem seems to be the refactoring of the connect/connect_robust method.
Now it passes the client_properties to make_url() which does not expect it, thus is becomes kwargs.
make_url(... **kwargs): ... kw = kwargs # <- {'client_properties': {'connection_name': 'A writer connection'}}` ... return URL.build( .... query=kw)
yarl url.build should get {'connection_name': 'A writer connection'}, not {'client_properties': {'connection_name': 'A writer connection'}}
The fix is, imho to add client_properties to the make_url arguments, and merge it with kw (similarly to the ssl_options).
well, I added the PR #469 fix
@viiand thank you for your contribution, following fixes released in 8.0.3
Hey there. I found an issue with the 8 version. client_properties cannot be passed to the aio_pika.connect_robust/connect anymore.
The problem seems to be the refactoring of the connect/connect_robust method.
Now it passes the client_properties to make_url() which does not expect it, thus is becomes kwargs.
yarl url.build should get {'connection_name': 'A writer connection'}, not {'client_properties': {'connection_name': 'A writer connection'}}
The fix is, imho to add client_properties to the make_url arguments, and merge it with kw (similarly to the ssl_options).