search

mosquito / aio-pika

AMQP 0.9 client designed for asyncio and humans.
https://aio-pika.readthedocs.org/
Apache License 2.0
1.23k stars 187 forks source link

improve typing in multiple library actors #478

Closed tvallois closed 2 years ago

tvallois commented 2 years ago

Closes #476

I tried to fix as many errors as Pyright found but some of them are libraries related and cannot be fix in an easy way (need to fix libraries from the bottom)

mosquito commented 2 years ago

This project already formatted with gray formatter.

mosquito commented 2 years ago

This project was formatted with 79 chars maximum line length.

mosquito commented 2 years ago

@tvallois please resolve conflicts and rebase.

mosquito commented 2 years ago

Something went wrong on rebase stage. Changes from default branch is now changes in your PR.

tvallois commented 2 years ago

Something went wrong on rebase stage. Changes from default branch is now changes in your PR.

Ok i'll rollback.

tvallois commented 2 years ago

Something went wrong on rebase stage. Changes from default branch is now changes in your PR.

Ok i'll rollback.

Ok i think i'm fine.

mosquito commented 2 years ago

@tvallois please run linter checks locally with tox -e lint, this will be faster than waiting my interaction with GH actions

tvallois commented 2 years ago

Hmm TypedDict does not exist in python version lower than 3.8. I can add typing_extensions dependency to resolve this but i'm not super fan to add dependencies just for this.

mosquito commented 2 years ago

@tvallois https://github.com/mosquito/aio-pika/runs/7562004324?check_suite_focus=true#step:5:24 TypedDict is not a part of python 3.7 stdlib. Sad but true.

tvallois commented 2 years ago

@tvallois https://github.com/mosquito/aio-pika/runs/7562004324?check_suite_focus=true#step:5:24 TypedDict is not a part of python 3.7 stdlib. Sad but true.

@mosquito Can replace with Dict[str, Any] or add typing_extensionsas described above.

mosquito commented 2 years ago

@tvallois released in aio-pika==8.1.1