Closed Olegt0rr closed 8 months ago
@Olegt0rr thanks for this PR, but I'm afraid you overdid it a bit. The fact is that now the main supported versions of python in this project are 3.7, 3.8, 3.9 and 3.10, and only in the latter the support for the loop
argument has beed dropped.
Your first commit was limited only to the fact that you removed this argument from the examples, which is good, I agree with this, but in order to remove this from the entire public API, I will have to bump the major version.
Agree :) The second commit reverted
If we consider docs then there is also
loop
parameter here https://github.com/mosquito/aio-pika/blame/master/docs/source/rabbitmq-tutorial/2-work-queues.rst#L162 and here https://github.com/mosquito/aio-pika/blob/master/docs/source/rabbitmq-tutorial/examples/6-rpc/rpc_client.py.
Now fixed
@mosquito did we dropped support of 3.6? If no then @Olegt0rr should left the usage of asyncio.get_event_loop
.
@mosquito I asked because we still have "Python 3.6+ compatible." in README.
@decaz fixed
Application developers should typically use the high-level asyncio functions, such as
asyncio.run()
, and should rarely need to reference theloop
object or call its methods