search

mosquito / aio-pika

AMQP 0.9 client designed for asyncio and humans.
https://aio-pika.readthedocs.org/
Apache License 2.0
1.18k stars 186 forks source link

Queue.declare() passive parameter not recognized #541

Closed Aurvandill closed 8 months ago

Aurvandill commented 1 year ago

In the Queue class the Function declare takes an argument called passive according to docstrings. Currently it does not. This PR adds it as an optional parameter. if no argument is given it will default to self.passive

Aurvandill commented 8 months ago

@mosquito any chance that you will take a look at this? with best regards Aurvandill

decaz commented 8 months ago

@Aurvandill passive parameter of a queue should be passed in channel.declare_queue method. After that Queue.declare inherits its value therefore there is inaccuracy in docstring of this method. Feel free to remove this parameter from docstring within current PR.

mosquito commented 8 months ago

So miss clicked actually 😅

Aurvandill commented 8 months ago

thanks for replying @decaz thanks for the explanation