search

mosquito / aiohttp-xmlrpc

XMLRPC for aiohttp
MIT License
34 stars 19 forks source link

Remove @asyncio.coroutine + 3.4 Support #26

Closed cooperlees closed 4 years ago

cooperlees commented 4 years ago

What are the thoughts of dropping 3.4 support and mainly @asyncio.coroutine decorator now we're in 2020 and many versions of Python ahead. This would be replaced with async def coroutine creation.

3.4 is not the default anymore on most popular Linux distros too.

graingert commented 4 years ago

this is also required for async/with support

mosquito commented 4 years ago

@graingert do you want to make PR?

mosquito commented 4 years ago

So Python 3.4 support might be dropped for new versions.

cooperlees commented 4 years ago

Thanks for dropping 3.4 support. It’s not support by Core Devs anymore. 3.4 users can pin to One of the the last 3.4 supporting versions.