Open wbenny opened 4 years ago
I believe this line doesn't belong there at all:
await asyncio.gather(self._reader_task, return_exceptions=True)
It was introduced here: https://github.com/mosquito/aiormq/commit/21860d5dead20ad5b8202dde35a676d5e45d2860#diff-ad998bcf1174a988f9e7d57468f6f146R452
Is my understanding correct?
Okay, I looked closer at the diff and realized that lined does belong there, but it should be executed before the self._reader_task = None
.
Here https://github.com/mosquito/aiormq/blob/master/aiormq/connection.py#L439 ... is this snippet of code:
self._reader_task
is being set toNone
and then given to theasyncio.gather()
. This obviously raises an exception:... which is usually conviniently and silently suppressed here: https://github.com/mosquito/aiormq/blob/master/aiormq/base.py#L139