search

mosquito / cysystemd

systemd wrapper on Cython
Apache License 2.0
101 stars 22 forks source link

A few small fixes in cysystemd.reader #61

Closed dairiki closed 11 months ago

dairiki commented 11 months ago

This PR includes three minor fixes to cysstemd.reader. (Let me know if you'd like me to split it into separate PRs.)

Fix JournalEntry.date

Sets the .tzinfo attribute of the datetime returned by the JournalEntry.date attribute. This fixes #60.

Fix JournalEntry.boot_id

Fixes the JournalEntry.boot_id method (and converts it to a property). It was totally broken — it just returned itself (a method instance).

Fix JournalOpenMode

Fixes JournalOpenMode making it an IntFlag rather than an IntEnum. It should be a flag — that is, it members can be bit-ORed with each other. The IntEnum does not allow that. In particular, I would like to be able to pass flags=0 to JournalReader.open in order to be able to implement the same functionality as passing the --merge option to journalctl

mosquito commented 11 months ago

@dairiki released as 1.6.0

dairiki commented 11 months ago

@mosquito Thank you!