mosra / m.css

A no-nonsense, no-JavaScript CSS framework, site and documentation theme for content-oriented websites

https://mcss.mosra.cz

Other

409 stars 92 forks source link

Remove Superfluous AnsiDefault class from console blocks #158

Closed blairconrad closed 4 years ago

blairconrad commented 4 years ago

Fixes #156

codecov[bot] commented 4 years ago

Codecov Report

Merging #158 into master will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files          27       27              
  Lines        6653     6649       -4     
  Branches       44       44              
==========================================
- Hits         6536     6532       -4     
  Misses        117      117

Impacted Files	Coverage Δ
plugins/ansilexer.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f161b3...dc12526. Read the comment docs.

blairconrad commented 4 years ago

Yay, ~green~ was green, now red!

I did a little unrelated work. First commit fixes a bad comment from the last PR. Last commit is totally optional. I didn't like the way the workaround looked , so reworked the lexing/parsing code a bit. Total refactor, no functional change. ef839b2 can be dropped with no ill effects if you don't like it.

I don't know what's going on with the coverage. It was happy until I rebased with the sole purpose of straightening out confusing dates. (I'd previously reordered commits, and github prefers date sorting to topological. So weird.) I don't know how I could've affected the documentation/python.py numbers!

blairconrad commented 4 years ago

And now green! I think the coverage numbers are maybe a little unreliable… This is probably something you already know.

blairconrad commented 4 years ago

@mosra, have I missed an action item or anything? Are you still interested in this PR?

mosra commented 4 years ago

Hi, yes I am, I'm just extremely busy lately and this wasn't one of the things that are on fire, so I didn't have a chance to act upon it yet. I'll see what can I do in the next weeks or so, sorry for the extreme delays.

blairconrad commented 4 years ago

No worries! Sorry to bother you. Just wanted to confirm that I wasn't holding you up. Carry on. No rush. No need to further salve my feelings. :wink:

mosra commented 4 years ago

OK, finally got to this. I don't really remember the particulars anymore but the output looks good and it's all your code anyway, so I trust you to know what you're doing :)

Merged as 3383879bc40d00e1368046ae18f802257b07ee2d...fbb2de6873e6b49cc2a92d2e67a87793ccede1e9, again apologies for the delay.

blairconrad commented 4 years ago

I don't really remember the particulars anymore but the output looks good and it's all your code anyway, so I trust you to know what you're doing :)

😆

No worries about the timing. Thanks for the merge. And the theme!