search

mosra / m.css

A no-nonsense, no-JavaScript CSS framework, site and documentation theme for content-oriented websites
https://mcss.mosra.cz
Other
406 stars 92 forks source link

Fix import errors in plugins #180

Closed shniubobo closed 3 years ago

shniubobo commented 3 years ago

Related issues: #178, https://github.com/getpelican/pelican/issues/2805

Since there are two seperate issues with Pelican 4.5.0 (one about import pelican.signals and the other about PLUGINS += ['m.htmlsanity']), I will open a new issue for the latter.

codecov[bot] commented 3 years ago

Codecov Report

Merging #180 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          27       27           
  Lines        6653     6653           
  Branches       44       44           
=======================================
  Hits         6536     6536           
  Misses        117      117
Impacted Files Coverage Δ
plugins/m/alias.py 100.00% <100.00%> (ø)
plugins/m/code.py 92.48% <100.00%> (ø)
plugins/m/dot.py 100.00% <100.00%> (ø)
plugins/m/dox.py 100.00% <100.00%> (ø)
plugins/m/filesize.py 89.18% <100.00%> (ø)
plugins/m/htmlsanity.py 93.36% <100.00%> (ø)
plugins/m/images.py 91.81% <100.00%> (ø)
plugins/m/math.py 92.39% <100.00%> (ø)
plugins/m/plots.py 99.24% <100.00%> (ø)
plugins/m/sphinx.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de86049...dbda4b6. Read the comment docs.

mosra commented 3 years ago

Wow, thanks a lot, I didn't have time to look into this yet and you already have the full fix :)

Checking the linked issue in Pelican, this means we'll have to wait a bit until a new version (with the proposed patch) is released, right?

shniubobo commented 3 years ago

Wow, thanks a lot, I didn't have time to look into this yet and you already have the full fix :)

Checking the linked issue in Pelican, this means we'll have to wait a bit until a new version (with the proposed patch) is released, right?

Yes, and maybe we could add a note in the plugins' documents that they are not compatible with pelican==4.5.0?

mosra commented 3 years ago

Yep, that definitely has to be documented :) So far I was basically telling everyone to stay on 4.2.