search

mosra / m.css

A no-nonsense, no-JavaScript CSS framework, site and documentation theme for content-oriented websites
https://mcss.mosra.cz
Other
406 stars 92 forks source link

Fixed autocomplete bug for documentation search.js on mobile devices #197

Closed smistad closed 2 years ago

smistad commented 3 years ago

Fixes issue #196 Detect if browser is on mobile device, and if so skip the appending of autocomplete text. Detecting mobile browser taken from here: https://stackoverflow.com/questions/11381673/detecting-a-mobile-browser

Should probably just hide the key guide in the search dialog as well on mobile since they are not relevant...?

codecov[bot] commented 3 years ago

Codecov Report

Merging #197 (1dd69b8) into master (3a29473) will decrease coverage by 0.10%. The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   98.28%   98.18%   -0.11%     
==========================================
  Files          27       27              
  Lines        6646     6655       +9     
  Branches       44       46       +2     
==========================================
+ Hits         6532     6534       +2     
- Misses        114      121       +7
Impacted Files Coverage Δ
documentation/search.js 98.07% <53.33%> (-1.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a29473...1dd69b8. Read the comment docs.

mosra commented 2 years ago

As mentioned in #196, this got solved in a different way in b59822342db1622a74ab4b95b844073ef93a2440, with an attempt to restore the autocompletion functionality stashed in #213.