Closed mosra closed 5 years ago
:exclamation: No coverage uploaded for pull request base (
master@f7d5d91
). Click here to learn what that means. The diff coverage is93.18%
.
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
Coverage ? 93.18%
=========================================
Files ? 26
Lines ? 1805
Branches ? 0
=========================================
Hits ? 1682
Misses ? 123
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
src/python/corrade/PybindExtras.h | 100% <100%> (ø) |
|
src/python/magnum/__init__.py | 100% <100%> (ø) |
|
src/python/magnum/NonDestructible.h | 100% <100%> (ø) |
|
src/python/magnum/platform/windowlessapplication.h | 100% <100%> (ø) |
|
src/python/magnum/trade.cpp | 100% <100%> (ø) |
|
src/python/magnum/math.h | 100% <100%> (ø) |
|
src/python/magnum/math.matrixfloat.cpp | 100% <100%> (ø) |
|
src/python/magnum/PyMesh.h | 100% <100%> (ø) |
|
src/python/corrade/EnumOperators.h | 100% <100%> (ø) |
|
src/python/corrade/__init__.py | 100% <100%> (ø) |
|
... and 16 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f7d5d91...7777943. Read the comment docs.
Eh, I would say this is enough for the initial MVP.
Split from https://github.com/mosra/magnum/pull/228. Things to do:
everythingreasonable base from the Math libxaxis()
might be okay butshearxz()
definitely isn't) -- went back to all underscores, everything else is inconsistentMatrix3.scaling()
vsmat.scaling()
)convince Python that it can have a property and static method of the same name (-- postponedMatrix3.translation()
vsmat.translation
)$<TARGET_EXISTS>
doesn't exist until CMake 3.12, need other solutionhow to support variadic templates (in particular Mesh::addVertexBuffer())?postponed*args
?(currently it's implicit and doesn't really work)it "just works" now