Skylion007 commented 3 years ago

Applies some of the performance fixes we discussed on Slack a few weeks ago to the magnum-bindings. Doesn't seem to be anything controversial in here, just adds some constant pointers.

mosra commented 3 years ago

You're awesome, thanks!

Looks good, I'll merge right once the CIs pass. There's a bit of contention right now so it might take a while :)

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 (41b720e) into master (4bb19e0) will decrease coverage by 0.02%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   91.14%   91.12%   -0.03%     
==========================================
  Files          40       40              
  Lines        4212     4212              
==========================================
- Hits         3839     3838       -1     
- Misses        373      374       +1

Impacted Files	Coverage Δ
src/python/magnum/gl.cpp	`96.08% <75.00%> (ø)`
src/python/corrade/containers.cpp	`86.25% <100.00%> (-0.22%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4bb19e0...41b720e. Read the comment docs.

Skylion007 commented 3 years ago

@mosra All tests pass.

mosra commented 3 years ago

:boom:

Thank you!

mosra / magnum-bindings

Apply clang-tidy performance fixes #10

Codecov Report