search

mosra / magnum-bindings

Bindings of the Magnum C++11 graphics engine into other languages
https://magnum.graphics
Other
19 stars 13 forks source link

Add bindings for Color name static functions (red, green, blue, ...) #12

Closed Skylion007 closed 2 years ago

Skylion007 commented 2 years ago

I noticed that the magnum Color class had some nice shortcut static functions for basic primary colors and that there were not exposed to Python. These PR adds them to Python.

codecov[bot] commented 2 years ago

Codecov Report

Merging #12 (02b119e) into master (4d5a9ed) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   90.99%   91.04%   +0.05%     
==========================================
  Files          43       43              
  Lines        4253     4277      +24     
==========================================
+ Hits         3870     3894      +24     
  Misses        383      383
Impacted Files Coverage Δ
src/python/magnum/math.vector.h 98.64% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d5a9ed...02b119e. Read the comment docs.

mosra commented 2 years ago

Merged as c50a2f68514495b6ca125297f1c7a39d02d5878c with a bunch of changes (added docstrings and tests). Thank you!

EDIT: oh, the public documentation won't get updated because the doc generation is broken with newer pybind versions for some reason, I have to fix that first.