Closed mCodingLLC closed 2 years ago
Merging #13 (40ba765) into master (dda7803) will increase coverage by
3.48%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 87.57% 91.05% +3.48%
==========================================
Files 43 43
Lines 3558 4283 +725
==========================================
+ Hits 3116 3900 +784
+ Misses 442 383 -59
Impacted Files | Coverage Δ | |
---|---|---|
src/python/magnum/meshtools.cpp | 93.33% <0.00%> (-6.67%) |
:arrow_down: |
src/python/magnum/trade.cpp | 96.32% <0.00%> (-2.90%) |
:arrow_down: |
src/python/corrade/containers.cpp | 85.71% <0.00%> (-1.01%) |
:arrow_down: |
src/python/magnum/shaders.cpp | 98.41% <0.00%> (-0.41%) |
:arrow_down: |
src/python/magnum/magnum.cpp | 100.00% <0.00%> (ø) |
|
src/python/corrade/corrade.cpp | 100.00% <0.00%> (ø) |
|
src/python/magnum/primitives.cpp | 100.00% <0.00%> (ø) |
|
src/python/magnum/scenegraph.trs.cpp | 100.00% <0.00%> (ø) |
|
src/python/magnum/math.matrixfloat.cpp | 100.00% <0.00%> (ø) |
|
src/python/magnum/math.vectorfloat.cpp | 100.00% <0.00%> (ø) |
|
... and 17 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dda7803...40ba765. Read the comment docs.
Hi, thanks for the contribution!
The change makes sense, but can you explain what triggered it so I know why this was needed? Was it due to an in-source CMake build, for example?
Sure thing, indeed this happened because I was doing an in-source build.
Thank you!
copyfile raises a SameFileError if the source and destination are the same. In this case, the error should be ignored.