search

mosra / magnum-bindings

Bindings of the Magnum C++11 graphics engine into other languages
https://magnum.graphics
Other
19 stars 13 forks source link

chore: remove extra copy in gl.cpp #19

Closed Skylion007 closed 2 years ago

Skylion007 commented 2 years ago

I was looking at the python bindings and noticed a perf bug. The reference count of owner in this context is unnecessarily increased, by using std::move we can just steal the reference instead.

mosra commented 2 years ago

Apologies for cancelling the CIs, I'm sure the change is fine but I'm having a bit of a month-end credit pressure :D

image

Will merge in October if that's fine.

mosra commented 2 years ago

Merged as 75be40300bcaf561256d1680e536b7cf18a79497, thanks!