search

mosra / magnum-bindings

Bindings of the Magnum C++11 graphics engine into other languages
https://magnum.graphics
Other
19 stars 13 forks source link

chore: Another missing move. Duplicated code. Duplicated bug #20

Closed Skylion007 closed 1 year ago

Skylion007 commented 2 years ago

@mosra A duplicated performance bug from one of my earlier PRs #17 .

mosra commented 2 years ago

Thank you!

Hmm, you know what? I'll just leave this PR open for a few weeks or until you find more, it's less work that way, for both of us ;)

codecov[bot] commented 2 years ago

Codecov Report

Base: 91.20% // Head: 91.20% // No change to project coverage :thumbsup:

Coverage data is based on head (4552ad9) compared to base (7a47c41). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20 +/- ## ======================================= Coverage 91.20% 91.20% ======================================= Files 45 45 Lines 4721 4721 ======================================= Hits 4306 4306 Misses 415 415 ``` | [Impacted Files](https://codecov.io/gh/mosra/magnum-bindings/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vladim%C3%ADr+Vondru%C5%A1) | Coverage Δ | | |---|---|---| | [src/Corrade/Containers/OptionalPythonBindings.h](https://codecov.io/gh/mosra/magnum-bindings/pull/20/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vladim%C3%ADr+Vondru%C5%A1#diff-c3JjL0NvcnJhZGUvQ29udGFpbmVycy9PcHRpb25hbFB5dGhvbkJpbmRpbmdzLmg=) | `100.00% <100.00%> (ø)` | | | [src/Magnum/PythonBindings.h](https://codecov.io/gh/mosra/magnum-bindings/pull/20/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vladim%C3%ADr+Vondru%C5%A1#diff-c3JjL01hZ251bS9QeXRob25CaW5kaW5ncy5o) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vladim%C3%ADr+Vondru%C5%A1). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vladim%C3%ADr+Vondru%C5%A1)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Skylion007 commented 1 year ago

@mosra You should be able to merge this PR now. Don't envision any other changes for a while.

mosra commented 1 year ago

Good idea -- merged as 695c40b2d1a0df1ced64483e73026d0b5b1c2839 :)