mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
99 stars 44 forks source link

Update to Oculus SDK 0.8.0.0-beta #10

Closed Squareys closed 8 years ago

Squareys commented 8 years ago

Hi @mosra !

This is an early PR to let you know I'm working on this. I actually found some old changes I forgot about in my local repository :D

TODOs:

(those TODOs were written late at night, my appologies for anything weird that may have resulted from that.)

Greetings, Squareys

mosra commented 8 years ago

Oh. Wow. Slow down, I can't keep up! :)

Now I have genuine fear that we get banned from the CIs soon :D

Squareys commented 8 years ago

I will try to stockpile more local commits before pushing, to grant the CIs a break every now and then.

mosra commented 8 years ago

I'm not complaining, it's just that the AppVeyor builds seemed to take three times longer than before (12 minutes vs. 4 minutes), like if we were throttled because of excessive activity :)

Squareys commented 8 years ago

@mosra Once again, done from my perspective. Can potentially be merged at the same time as https://github.com/mosra/magnum-examples/pull/19 :)

Squareys commented 8 years ago

@mosra Hey, you're back! :D I will take some time on the changes you proposed, probably wont find time before the weekend, just FYI.

Squareys commented 8 years ago

@mosra Alright, I finally got around to taking care of the flaws you pointed out! :)

mosra commented 8 years ago

:+1: Merged.

I just rebased the commits to current master and did a single change -- removed redundant prefix from the OvrDetectResult enum. Hope that's okay.

Squareys commented 8 years ago

Hope that's okay.

No problem, of course, thanks!