Update to Oculus SDK 1.3.0

mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine

https://magnum.graphics/

Other

99 stars 44 forks source link

Update to Oculus SDK 1.3.0 #12

Closed Squareys closed 8 years ago

Squareys commented 8 years ago

Hello everybody!

The first non beta version of the Oculus SDK has finally been released and I'm working on updating OvrIntegration respectively.

TODO:

[x] Figure out what's going on with the layers (some removed, LayerEyeMatrix added)
[x] Adapt to mirror texture changes
[x] Make sure documentation is still correct
[x] Other minor changes and renaming
- [x] Changes in ErrorType enum
- [x] Add TrackingOrigin enum and Hmd::setTrackingOriginType()
[x] Fix FindOVR.cmake (for MSVC)*
[x] Wrap input related API
- [x] Add ControllerType enum
- [x] Get controller state
- [x] Get tracker poses
[x] Rename Hmd to Session

* Not tested yet. AppVeyor fails at downloading the Oculus SDK.

This should be done this Sunday.

Regards, Jonathan.

mosra commented 8 years ago

Wow, awesome, you are continuously doing great job! :)

Didn't look into the changes yet, just an idea that came up on my mind -- could you try enabling the library on AppVeyor for MSVC 2015? It's explicitly set to OFF because there were linker problems before. I'm curious to see whether it works already or not.

Squareys commented 8 years ago

Well, AppVeyor really does not seem to want to download the SDK...

Squareys commented 8 years ago

In the last SDK update ovrHmd was renamed to ovrSession, which we could/should follow with Hmd (This is sane, since you require the session to get controller input state, which semantically does not make sense to get from the headset). Three options:

Don't rename
Rename, but keep an alias to not break outside code (who cares, I guess, others can do that themselves if they must)
Complete rename of Hmd to Session

I'd prefer the last. What do you say, @mosra?

mosra commented 8 years ago

Rename Hmd to Session.

We're not doing any more harm than Oculus itself when doing those renames, so that's okay.

Squareys commented 8 years ago

@mosra I'm basically done here! I might stumble over the one or the other change in the SDK so there might be one or two more commits over the next week, but apart from that this should be complete.

mosra commented 8 years ago

Great! :) Will go over it in the next few days and merge.

The AppVeyor build is failing with strange error, though. Never seen that before. Do you have an idea what could cause that?

Squareys commented 8 years ago

@mosra Yes, it was because I passed an aligned structure by value instead of const ref. Should have fixed it :)

mosra commented 8 years ago

:+1:

The only concern I have are the masks for Buttons and Touches, the rest are just minor issues. First-class work again! :)

Squareys commented 8 years ago

@mosra Alright, I fixed all the minor issues. The solution you proposed for Buttons and Touches does not quite work as hoped. I understand why the initial solution is not nice, so I will try to find another solution for that.

mosra commented 8 years ago

Merged in ff7b924edbf445f24b49a022cb0d7a4d45ba4752, sorry it took so long. I did a rough cleanup and review of the code, but because the PR was already quite big, I put the comments into a separate issue: #13. If you could go over it once you have time, that would be great. It's not extreme high priority, though, you have other things to focus on :)