search

mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
99 stars 44 forks source link

Cleanup OvrIntegration issues #15

Closed Squareys closed 8 years ago

Squareys commented 8 years ago

Hi @mosra !

I finally got around to cleaning up #13... sorry it took me so long. And sorry for the mess, some of the things I fixed were rather sloppy.

Regards, Jonathan.

PS: Take your time with the review, I will need to compile check the example still anyway, and this shouldn't be urgent in any way.

mosra commented 8 years ago

Thanks a lot! :+1:

I still saw mentions of the OVR API instead of the wrapped API in the error enum, can you look there also?

Squareys commented 8 years ago

@mosra I addressed the new issues (de-inlined the Compositor constructor, referenced OvrIntegration types in errors enum and added the std::). This could possibly be good to go now :)

Regards, Squareys.

Squareys commented 8 years ago

@mosra Rebased and removed error enum values to know be OculusSDK 1.6.0 compliant!

I would be really happy, if this could get merged in the next 7 days, if that is possible somehow :)

PS: Hooooly.... AppVeyor was quick this time :O

mosra commented 8 years ago

Merged. Thanks a lot!