Closed costashatz closed 6 years ago
Merging #29 into master will decrease coverage by
8.79%
. The diff coverage is45.42%
.
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
- Coverage 55.33% 46.53% -8.8%
=========================================
Files 12 12
Lines 253 462 +209
=========================================
+ Hits 140 215 +75
- Misses 113 247 +134
Impacted Files | Coverage Δ | |
---|---|---|
src/Magnum/DartIntegration/Object.h | 0% <0%> (ø) |
|
src/Magnum/DartIntegration/World.h | 0% <0%> (ø) |
|
src/Magnum/DartIntegration/Object.cpp | 1.14% <1.14%> (ø) |
|
src/Magnum/DartIntegration/World.cpp | 1.31% <1.31%> (ø) |
|
src/Magnum/DartIntegration/ConvertShapeNode.h | 100% <100%> (ø) |
:arrow_up: |
src/Magnum/DartIntegration/ConvertShapeNode.cpp | 92.85% <92.54%> (+49.81%) |
:arrow_up: |
src/Magnum/BulletIntegration/ConvertShape.cpp | 35.71% <0%> (-0.65%) |
:arrow_down: |
src/Magnum/BulletIntegration/MotionState.cpp | 100% <0%> (ø) |
:arrow_up: |
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e9b193d...f0dc765. Read the comment docs.
@mosra I think it's time that you can check more thoroughly what I've written and give me your thoughts/comments on the code and the 2 last bullets remaining (about the pointers).. Of course I will work on the documentation more.. :smile:
Thanks!
Merged, thanks a lot. Code coverage including GL tests says 92%, you're doing amazing work :+1: :tada:
I made a few small changes to the public API that might break your code, see e3efe6de0791242a53324873ce571003fc617712, 3c3d554f7330ddbbc52acdabff0ba33c35ed1f43 and 7676fdb34e22eb8edde46fdc3023edb524e408c5. In 016c2527f7da3b10a2277cf0be9e6b7cded5ad7e I removed a public function that I think was superfluous and never used in any code, I hope that's okay.
Looking forward to the example now :)
This PR improves the DartIntegration introduced in #28 .. It is still work in progress, but at a quite good state:
DartIntegration::Object
Provide default behavior (i.e, remove it from scene) when an Object is deleted from the DART world; maybe we do not need to add thisSoftMeshShape
; for now we are rendering them without normalsstd::shared_ptr
; maybe replace it withstd::unique_ptr
? It could not be a good idea to haveunique_ptr
s as you may need to use the pointers to check whether a mesh is already created/or notFor an example usage, you can have a look at this branch, which I am updating to match the updates on this integration.
Let me know what you think!