Closed matjam closed 6 years ago
Merging #31 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #31 +/- ##
=======================================
Coverage 49.41% 49.41%
=======================================
Files 12 12
Lines 425 425
=======================================
Hits 210 210
Misses 215 215
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b2a285f...2e1ea16. Read the comment docs.
Hmm. Unlike in the other PRs, here you don't mention corrade
and corrade-dev
among dependencies. Is that intentional?
(Same is in the example repo.)
hmm, might not have been necessary?
I'd have to go and rebuild everything in launchpad to check ... yikes.
Merged in 58d681bf9626aaa85815722524711ae591f7b5c4. Thanks! :)
As promised in https://github.com/mosra/magnum/issues/248, here is a PR that will allow builds to work for both Ubuntu 18.04 and 16.04. Note that some of the changes are also to allow the build to work correctly in Launchpad, as it builds from a clean chroot every time dependencies may not be available.