mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
99 stars 44 forks source link

fix to allow building on both Ubuntu 16.04 and 18.04. #31

Closed matjam closed 6 years ago

matjam commented 6 years ago

As promised in https://github.com/mosra/magnum/issues/248, here is a PR that will allow builds to work for both Ubuntu 18.04 and 16.04. Note that some of the changes are also to allow the build to work correctly in Launchpad, as it builds from a clean chroot every time dependencies may not be available.

codecov-io commented 6 years ago

Codecov Report

Merging #31 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   49.41%   49.41%           
=======================================
  Files          12       12           
  Lines         425      425           
=======================================
  Hits          210      210           
  Misses        215      215

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2a285f...2e1ea16. Read the comment docs.

mosra commented 6 years ago

Hmm. Unlike in the other PRs, here you don't mention corrade and corrade-dev among dependencies. Is that intentional?

(Same is in the example repo.)

matjam commented 6 years ago

hmm, might not have been necessary?

I'd have to go and rebuild everything in launchpad to check ... yikes.

mosra commented 6 years ago

Merged in 58d681bf9626aaa85815722524711ae591f7b5c4. Thanks! :)