mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
99 stars 44 forks source link

imgui including problem #45

Closed sariug closed 5 years ago

sariug commented 5 years ago

Hello, sorry for creating new issue(new in this community, not sure if its the best thing.)

I tried implementing imgui in magnum however, it failed nonstop. you guyz seem to provide findimgui.cmake however imgui itself is not a cmake-able. How should I proceed to include imgui with my magnum developments.

Also since you and imgui is developing nonstop is there a suggesting commit that should work without problem.

Sorry to copy the issue

mosra commented 5 years ago

Hi @sariug!

ImGui itself has no cmake support, so magnum's FindImGui.cmake only gathers its sources and compiles them together with the integration library. Without knowing where exactly it failed for you (and what system are you on etc.) I can't help much, but one important thing that needs to be done is setting the IMGUI_DIR variable to point to the ImGui sources (the Git clone etc.). The CMake setup for the magnum-integration repository usually looks like this:

mkdir build && cd build
cmake .. \
    -DCMAKE_PREFIX_PATH=<where-magnum-is-installed> \
    -DIMGUI_DIR=<where-imgui-sources-are> \
    -DWITH_IMGUI=ON \
    ...

The latest ImGui version we're certain is working as expected is 1.67. Newer versions should work too, but I'm not tracking the upstream development closely so there might be breaking changes I'm not aware of.

Hope this helps! :)

sariug commented 5 years ago

worked ! Thank you !

mosra commented 5 years ago

You're welcome! :)

Note you need to pass IMGUI_DIR also for all projects that use the ImGuiIntegration library, as this information doesn't get transferred during installation.