mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
99 stars 44 forks source link

DartIntegration-v3 #47

Closed costashatz closed 5 years ago

costashatz commented 5 years ago

DartIntegration: This pull request fixes a small bug in the cylinder shape and adds support for the cone shape..

codecov-io commented 5 years ago

Codecov Report

Merging #47 into master will increase coverage by 0.43%. The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   74.73%   75.17%   +0.43%     
==========================================
  Files          21       21              
  Lines         847      862      +15     
==========================================
+ Hits          633      648      +15     
  Misses        214      214
Impacted Files Coverage Δ
src/Magnum/DartIntegration/ConvertShapeNode.h 100% <ø> (ø) :arrow_up:
src/Magnum/DartIntegration/World.cpp 0% <0%> (ø) :arrow_up:
src/Magnum/DartIntegration/ConvertShapeNode.cpp 96.13% <100%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40011af...ebd4fb0. Read the comment docs.

mosra commented 5 years ago

Merged in e78af90b475f98d992a3493c33e4d85a3f592bcf, 398feb7dd2489d4baeb62e200a56bb0471f2553f, 50e7ec2f1dba6e282a219301ba7ba60280462b63, 33f45c778d55761104fcd03fe26ec33b46083f42, 7964c6dc8505b1c1de2fa9c0860744304ad01113 and dc029da8c2fcba503442af90e54d3145aef4e166. Thanks a lot for the continued maintenance!