mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
97 stars 44 forks source link

DartIntegration: use EigenIntegration and small check for NaN values #58

Closed costashatz closed 4 years ago

costashatz commented 4 years ago

This PR adds the following to the DartIntegration:

codecov-io commented 4 years ago

Codecov Report

Merging #58 into master will decrease coverage by 0.32%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   74.77%   74.44%   -0.33%     
==========================================
  Files          21       21              
  Lines         880      900      +20     
==========================================
+ Hits          658      670      +12     
- Misses        222      230       +8
Impacted Files Coverage Δ
src/Magnum/DartIntegration/Object.cpp 0% <0%> (ø) :arrow_up:
src/Magnum/ImGuiIntegration/Context.hpp 87.5% <0%> (-12.5%) :arrow_down:
src/Magnum/GlmIntegration/GtxIntegration.h 100% <0%> (ø) :arrow_up:
src/Magnum/GlmIntegration/GtcIntegration.h 100% <0%> (ø) :arrow_up:
src/Magnum/EigenIntegration/Integration.h 100% <0%> (ø) :arrow_up:
src/Magnum/GlmIntegration/Integration.h 100% <0%> (ø) :arrow_up:
src/Magnum/EigenIntegration/GeometryIntegration.h 100% <0%> (ø) :arrow_up:
src/Magnum/ImGuiIntegration/Context.h 100% <0%> (ø) :arrow_up:
src/Magnum/ImGuiIntegration/Context.cpp 83.13% <0%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88bd1a2...dc8e10c. Read the comment docs.

mosra commented 4 years ago

Merged as f55a61664532999bf91904b75d312252413af949 and 95d46a3c234423a70f482335db709e5b045fa857, thank you!