search

mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
97 stars 44 forks source link

ImGuiIntegration: Fix assertion when move assigning empty context #63

Closed Squareys closed 4 years ago

Squareys commented 4 years ago

@mosra As discussed via gitter, here's the follow-up fix for #62 .

Best, Jonathan.

codecov-io commented 4 years ago

Codecov Report

Merging #63 into master will decrease coverage by 18.88%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
- Coverage   74.45%   55.56%   -18.89%     
===========================================
  Files          21       19        -2     
  Lines         912      844       -68     
===========================================
- Hits          679      469      -210     
- Misses        233      375      +142
Impacted Files Coverage Δ
src/Magnum/ImGuiIntegration/Context.cpp 2.71% <0%> (-81.44%) :arrow_down:
src/Magnum/ImGuiIntegration/Context.h 100% <0%> (ø) :arrow_up:
src/Magnum/ImGuiIntegration/Widgets.h
src/Magnum/ImGuiIntegration/Context.hpp

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31c9235...e17f7de. Read the comment docs.