mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
97 stars 44 forks source link

Eigen <-> StridedArrayView integration #74

Closed Janos95 closed 3 years ago

Janos95 commented 4 years ago

This patch provides an arrayCast method converting between Eigen expressions and Corrade's StridedArrayView class. Not the most beautiful code in the world but should mostly work ;).

codecov-commenter commented 4 years ago

Codecov Report

Merging #74 into master will increase coverage by 14.33%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #74       +/-   ##
===========================================
+ Coverage   75.13%   89.47%   +14.33%     
===========================================
  Files          21       16        -5     
  Lines         905      570      -335     
===========================================
- Hits          680      510      -170     
+ Misses        225       60      -165     
Impacted Files Coverage Δ
src/Magnum/EigenIntegration/Integration.h 100.00% <100.00%> (ø)
src/Magnum/GlmIntegration/Integration.cpp 92.85% <0.00%> (-3.58%) :arrow_down:
src/Magnum/BulletIntegration/DebugDraw.cpp 13.88% <0.00%> (-2.78%) :arrow_down:
src/Magnum/BulletIntegration/MotionState.cpp 84.21% <0.00%> (-1.51%) :arrow_down:
src/Magnum/DartIntegration/Object.cpp
src/Magnum/DartIntegration/ConvertShapeNode.cpp
src/Magnum/DartIntegration/Object.h
src/Magnum/DartIntegration/World.cpp
src/Magnum/DartIntegration/ConvertShapeNode.h
src/Magnum/ImGuiIntegration/Context.cpp 90.90% <0.00%> (+3.40%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5562e1...f686010. Read the comment docs.

mosra commented 3 years ago

Finally merged as e8eceb3a27317d36f37af68fdd0fc593b83a51b3, thank you! :pray: (and sorry for the several month delay)

As I mentioned in the comment above, 9379c6411a8ac95abc9bc0a7e5c2a8e95b0df4a7 removes the RowMajor from the Map typedef -- can you quickly verify it makes sense? I'm not "Eigen native" so I'm not 100% sure this doesn't break anything. Thanks again!