search

mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
99 stars 44 forks source link

Linking failure with ImGui HEAD #81

Closed Gollum999 closed 3 years ago

Gollum999 commented 3 years ago

Looks like ImGui added a new source file in a recent commit: imgui_tables.cpp. This causes linking errors like the following:

imgui.obj : error LNK2019: unresolved external symbol "void __cdecl ImGui::EndTable(void)" (?EndTable@ImGui@@YAXXZ) referenced in function "void __cdecl Im
Gui::ErrorCheckEndFrameRecover(void (__cdecl*)(void *,char const *,...),void *)" (?ErrorCheckEndFrameRecover@ImGui@@YAXP6AXPEAXPEBDZZ0@Z) [C:\code\SaikoEng
ine\bld\vs\external\magnum-integration\src\Magnum\ImGuiIntegration\MagnumImGuiIntegration.vcxproj]
imgui_demo.obj : error LNK2001: unresolved external symbol "void __cdecl ImGui::EndTable(void)" (?EndTable@ImGui@@YAXXZ) [C:\code\SaikoEngine\bld\vs\extern 
al\magnum-integration\src\Magnum\ImGuiIntegration\MagnumImGuiIntegration.vcxproj]

I see the list of expected source file is hard-coded here. Presumably that will need to change, and change in such a way that it supports both old and new versions of ImGui.

pezcode commented 3 years ago

If you pull master again, that should be fixed with https://github.com/mosra/magnum-integration/commit/1f79ba71b9f0ece204dd9ba31b06871653c0d546 :eyes:

Gollum999 commented 3 years ago

Seems to work. Thanks for the quick fix!