search

mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
99 stars 45 forks source link

ImGuiIntegration: use provided index offset #88

Closed pezcode closed 2 years ago

pezcode commented 2 years ago

Closes https://github.com/mosra/magnum-integration/issues/86

codecov[bot] commented 2 years ago

Codecov Report

Merging #88 (b471f2c) into master (da3c1ab) will decrease coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   77.25%   77.20%   -0.05%     
==========================================
  Files          21       21              
  Lines         941      939       -2     
==========================================
- Hits          727      725       -2     
  Misses        214      214
Impacted Files Coverage Δ
src/Magnum/ImGuiIntegration/Context.cpp 90.13% <100.00%> (-0.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da3c1ab...b471f2c. Read the comment docs.

jvannugteren commented 2 years ago

Thanks. This fix solves the issues in my usecase.

pezcode commented 2 years ago

Same caveat as here: https://github.com/mosra/magnum-integration/pull/90#issuecomment-1016723574

mosra commented 2 years ago

Thank you! Merged as 3e7b175385b85fba8eeb0cbdb8051a59f3e075b6.

For the record, we agreed on not supporting ImGui releases older than 2 years, so it's fine this change raises the minimum requirement to 1.71.