mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
99 stars 44 forks source link

Update to Oculus SDK 0.7.0.0-beta #9

Closed Squareys closed 9 years ago

Squareys commented 9 years ago

Hello everybody!

This is a work-in-progress pullrequest for the update of the former LibOvrIntegration (now OvrIntegration), mentioned in #8 .

TODOs left:

Greetings, Squareys

Squareys commented 9 years ago

This is very close to done. I will go through the code for some cleanup tomorrow.

Squareys commented 9 years ago

This and https://github.com/mosra/magnum-examples/pull/15 are both ready for merge from my side.

Squareys commented 9 years ago

I will be able to look after the issues you pointed out this evening.

Squareys commented 9 years ago

@mosra Alright, those two issues are done.

Squareys commented 9 years ago

@mosra If there are any other issues, just let me know :)

mosra commented 9 years ago

Merged except for the NoInit commit (Squareys/magnum-integration@a27713ebb52220c322eaf9f89ccc351ec9d16edc), will merge that one too when the crash mentioned above is resolved.

mosra commented 9 years ago

@Squareys: latest Corrade (mosra/corrade@8d1b47e818b924042dd516700d462f6d9b64f845) has custom deleters for Array, which should fix the NoInit issue. Can you please verify if the crash is gone now? You may need to rebuild Magnum too.

Thanks a lot.

Squareys commented 9 years ago

@mosra The crash is gone! Thank you, too!

mosra commented 9 years ago

Awesome, closing as merged.