mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
97 stars 44 forks source link

ImguiIntegration: support for imgui IO event API #93

Closed pezcode closed 2 years ago

pezcode commented 2 years ago

This adds support for the new IO handling about to land in imgui 1.87. The main advantages:

A few notes:

Todo:

codecov[bot] commented 2 years ago

Codecov Report

Merging #93 (a29dea2) into master (da3c1ab) will decrease coverage by 0.19%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   77.25%   77.06%   -0.20%     
==========================================
  Files          21       21              
  Lines         941      933       -8     
==========================================
- Hits          727      719       -8     
  Misses        214      214              
Impacted Files Coverage Δ
src/Magnum/ImGuiIntegration/Context.cpp 89.13% <100.00%> (-1.13%) :arrow_down:
src/Magnum/ImGuiIntegration/Context.hpp 86.48% <100.00%> (+1.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da3c1ab...a29dea2. Read the comment docs.

mosra commented 2 years ago

Merged as c60149c818bbdf61d97f30706f2018d968930718 (I squashed all changes together since it didn't seem to make sense to preserve the later-removed temporary hack), thanks a lot!