search

mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
97 stars 44 forks source link

ImGuiIntegration: Add conversion between ImStrv and StringView #96

Open hugoam opened 2 years ago

hugoam commented 2 years ago

Hello ! This one is kind of self-explanatory :) Do you think we could merge something in this spirit?

mosra commented 2 years ago

Yes, absolutely! :)

Couldn't find this in the main imgui branch, so I suppose it's originating from this PR, right? https://github.com/ocornut/imgui/pull/3038 Can you add a bit of documentation, in a similar spirit to the other types listed above? Especially mentioning the PR/branch, and the IMGUI_HAS_IMSTR macro. And a test case as well, into Test/IntegrationTest.cpp. Thanks!

mosra commented 2 years ago

Apologies for cancelling the CI, I have very little free CircleCI credits left for June and saving them for emergency reasons :fire:

If you can wait with pushing until July 1st, that'd be best. Thanks :sweat_smile:

mosra commented 2 years ago

Actually, I just went and temporarily disabled PR builds on CircleCI, so that should preserve the scarce minutes, hopefully. AppVeyor could be enough to verify correctness, ImGui is tested there as well I hope.

But due to CircleCI I'll likely not merge before 1st, sorry :sweat_smile:

mosra commented 2 years ago

@hugoam ping ;)

hugoam commented 2 years ago

Sorry, didn't have much time to look at this again and then I went on a vacation. I'll try to have a look soonish, I promise