mosra / magnum-integration

Integration libraries for the Magnum C++11 graphics engine
https://magnum.graphics/
Other
97 stars 44 forks source link

MSYS .gitattributes typo: Wrong line ending normalization under Windows #97

Closed lacyyy closed 2 years ago

lacyyy commented 2 years ago

Typo in https://github.com/mosra/magnum-integration/blob/master/package/msys/.gitattributes

magnum/PKGBUILD text eof=lf
PKGBUILD text eof=lf

There is no attribute named eof, they're supposed to be eol attributes. Because of this typo, Git on Windows wrongly normalizes the PKGBUILD files to CRLF line endings. Last time I reported this typo in the other magnum repos I didn't know this repo existed 😄

mosra commented 2 years ago

Ah damn, sorry! :sweat_smile: I thought I checked for the same problem everywhere, but apparently not.

Will push a fix tomorrow.

mosra commented 2 years ago

Pushed (with you as an author) as 49f345923539eb56240c3179e14a552e31e058c3. Sorry again for the mess! :D