mosra / magnum

Lightweight and modular C++11 graphics middleware for games and data visualization
https://magnum.graphics/
Other
4.75k stars 439 forks source link

Platform: add missing modifier and command keys to Sdl2Application #547

Closed pezcode closed 2 years ago

pezcode commented 2 years ago

These keys already exist in GlfwApplication and EmscriptenApplication, enum names are taken from there. Key codes exist as far back as SDL 2.0.

codecov[bot] commented 2 years ago

Codecov Report

Merging #547 (4eb6cc2) into master (5f16354) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 4eb6cc2 differs from pull request most recent head aed581f. Consider uploading reports for the commit aed581f to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   84.01%   83.99%   -0.02%     
==========================================
  Files         519      519              
  Lines       33614    33441     -173     
==========================================
- Hits        28242    28090     -152     
+ Misses       5372     5351      -21     
Impacted Files Coverage Δ
src/Magnum/Shaders/MeshVisualizerGL.h 89.87% <0.00%> (-2.86%) :arrow_down:
src/Magnum/Shaders/MeshVisualizerGL.cpp 76.02% <0.00%> (-0.92%) :arrow_down:
src/Magnum/Shaders/FlatGL.cpp 85.71% <0.00%> (-0.89%) :arrow_down:
src/Magnum/Shaders/PhongGL.cpp 79.23% <0.00%> (-0.69%) :arrow_down:
src/Magnum/GL/Mesh.h 97.97% <0.00%> (-0.03%) :arrow_down:
src/Magnum/Shaders/Flat.h 100.00% <0.00%> (ø)
src/Magnum/Shaders/Phong.h 100.00% <0.00%> (ø)
src/Magnum/Shaders/FlatGL.h 52.94% <0.00%> (ø)
src/Magnum/Shaders/PhongGL.h 87.09% <0.00%> (ø)
src/Magnum/Shaders/MeshVisualizer.h 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f16354...aed581f. Read the comment docs.

mosra commented 2 years ago

Thank you! Merged as b1ec6aa5b86053b03f32cb71e9762a90bb60dc4a and d5db913a77cde07d1fe2cb9700c6da588e4a068f.