search

mosra / magnum

Lightweight and modular C++11 graphics middleware for games and data visualization
https://magnum.graphics/
Other
4.75k stars 439 forks source link

GL: add Framebuffer::InvalidationAttachment::DepthStencil #554

Closed pezcode closed 2 years ago

pezcode commented 2 years ago

Small quality-of-life improvement. May not make any real difference in the driver since the relevant extension mentions that you can invalidate a packed depth-stencil attachment by invalidating either of the two, but it's useful for code expressiveness.

codecov[bot] commented 2 years ago

Codecov Report

Merging #554 (adfc850) into master (49bcbed) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         524      524           
  Lines       33956    33956           
=======================================
  Hits        28480    28480           
  Misses       5476     5476
Impacted Files Coverage Δ
src/Magnum/GL/Framebuffer.cpp 54.24% <ø> (ø)
src/Magnum/GL/Framebuffer.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49bcbed...adfc850. Read the comment docs.

mosra commented 2 years ago

Merged as 95f4124b5bce51156c1d100a8d7d6a7ea0822b59 (somehow my suggestions caused whitespace on EOL :eyes:, so I cleaned them up). Thank you!