Open mosra opened 2 years ago
Merging #567 (5a8d317) into master (a218ddf) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 83.89% 83.90% +0.01%
==========================================
Files 523 523
Lines 33999 34013 +14
==========================================
+ Hits 28524 28540 +16
+ Misses 5475 5473 -2
Impacted Files | Coverage Δ | |
---|---|---|
...agnumPlugins/AnyImageConverter/AnyImageConverter.h | 100.00% <ø> (ø) |
|
.../MagnumPlugins/AnyImageImporter/AnyImageImporter.h | 100.00% <ø> (ø) |
|
...numPlugins/AnyImageConverter/AnyImageConverter.cpp | 65.74% <100.00%> (+1.30%) |
:arrow_up: |
...agnumPlugins/AnyImageImporter/AnyImageImporter.cpp | 87.34% <100.00%> (+1.37%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a218ddf...5a8d317. Read the comment docs.
Even though
KtxImporter
/KtxImageConverter
doesn't support these (and probably never will), the rationale here is to provide a somewhat better message than "unable to detect file format" when trying to open a*.ktx
file, or when trying to save to a*.ktx
by accident, instead of*.ktx2
(which I do quite often). The concrete plugins are able to provide a much better error message about version 1 not supported.However, this means that once some new plugin actually supports KTX1,
KtxImporter
will still get picked over it, since it always has a precedence over any alias. So this might actually be counterproductive, ending up in the same endless pain as is with the still pretty much uselessly bareboneObjImporter
being picked overAssimpImporter
. Different ideas?*.ktx
file.Ktx1Importer
/Ktx1ImageConverter
, which won't have any matching plugin in the foreseeable future (and thus also being utterly confusing?)Ktx1Importer
/Ktx1ImageConverter
for it? I don't know about any, and integrating Khronos' KTX Software (which depend on GLUT and whatnot) is one thing I definitely did not want and thus went with plugins implemented from scratch instead. OIIO is flexible but doesn't seem to support KTX and there doesn't seem to be any interest in adding that.KtxImporter
/KtxImageConverter
? Ugh. Actually, integrating KTX Software seems a better idea than wasting time implementing KTX1 myself, but it would need to have some other added value than just being able to work with KTX1.