search

mosra / magnum

Lightweight and modular C++11 graphics middleware for games and data visualization
https://magnum.graphics/
Other
4.75k stars 439 forks source link

Wrong line ending normalization under Windows due to typo in .gitattributes #574

Closed lacyyy closed 2 years ago

lacyyy commented 2 years ago

Typo in https://github.com/mosra/magnum/blob/master/package/msys/.gitattributes

magnum/PKGBUILD text eof=lf
PKGBUILD text eof=lf

There's no eof attribute, only the eol attribute, hence it should be:

magnum/PKGBUILD text eol=lf
PKGBUILD text eol=lf

Because of this typo, Git on Windows wrongly normalizes the PKGBUILD files to CRLF line endings.

The same bug and typo is present in https://github.com/mosra/magnum-plugins/blob/master/package/msys/.gitattributes where I'll open an issue as well.

mosra commented 2 years ago

Commited as c5781f42fe6412b2386aeb8b842b423c416aa5ef, thank you! I wonder how it went unnoticed for so long.