mosra / magnum

Lightweight and modular C++11 graphics middleware for games and data visualization
https://magnum.graphics/
Other
4.75k stars 439 forks source link

Split Sdl2Application mainLoopIteration #577 #580

Open AndreasLrx opened 2 years ago

AndreasLrx commented 2 years ago

Split Sdl2Application mainLoopIteration in:

I did not split up the mainLoopIteration of the GlfwApplication/AbstractXApplication yet because the tickEvent isn't implemented in either of them. Should I omit the mainLoopTickEvent() or implement the tickEvent() for the others applications with the same implementation as the one in Sdl2Application ? Or either don't even split the mainLoopIteration ? (I didn't looked at their usages and therefore don't know if it might be usefull or not)

Linked: #577

codecov[bot] commented 2 years ago

Codecov Report

Merging #580 (ac2351b) into master (e5d3ec8) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files         531      531           
  Lines       37613    37613           
=======================================
  Hits        31043    31043           
  Misses       6570     6570           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mosra commented 1 year ago

This is awesome, thank you. I have no other comments, I'll get to merging this hopefully during the weekend.

AndreasLrx commented 1 year ago

Sorry I forgot to remove the PR from draft. I might suggest other changes when working on my project ;).