Utility: use Corrade String and StringView in ConfigurationValue

mosra / magnum

Lightweight and modular C++11 graphics middleware for games and data visualization

https://magnum.graphics/

Other

4.78k stars 441 forks source link

Utility: use Corrade String and StringView in ConfigurationValue #582

Open hugoam opened 2 years ago

hugoam commented 2 years ago

Hello ! We're trying to optimize our compile times and I noticed that StlForwardString.h is actually very heavy on MSVC because it just directly includes , so I thought let's go and try to clean this up. Let me know if I'm going at this correctly 😅

Associated Corrade PR: https://github.com/mosra/corrade/pull/146

mosra commented 2 years ago

As we discussed in mosra/corrade#146, I merged a part of this as 8b45a5170c9e21ad2a29a3c8224fc5b5995fe9b0. Thank you!

Leaving the PR open, will merge the rest when I get to cleaning up STL usage in Utility::Arguments and Utility::Configuration -- until then the remaining changes don't make a big difference.

hugoam commented 2 years ago

Thanks so much ! Yeah, the rest doesn't matter too much for us as it doesn't affect compile times, so, I don't mind, you can even close it hehe

mosra commented 2 years ago

It matters for me ;)