mosra
commented
1 year ago Same as before -- to save us both time, next time you need a certain change, please ask first and describe your use case. You're on Gitter already anyway, so just post a question there. Magnum is not the type of a project where I just merge any description-less PR that gets opened, and if things are done in a certain way, in most cases there's a reason why, and every change requires backwards compatibility considerations to avoid breaking dozens of existing projects.
In this case, the *Application classes are deliberately using a mutable int& and a mutable char** to allow user code to modify the argc/argv parameters. For example to filter away certain arguments to avoid "unknown argument" errors. Qt does the same, by the way.
Codecov Report
Base: 81.26% // Head: 81.26% // No change to project coverage :thumbsup:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #603 +/- ## ======================================= Coverage 81.26% 81.26% ======================================= Files 532 532 Lines 38965 38965 ======================================= Hits 31665 31665 Misses 7300 7300 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vladim%C3%ADr+Vondru%C5%A1). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vladim%C3%ADr+Vondru%C5%A1):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.