mosswg / dropout-dl

A tool for downloading dropout.tv episodes
GNU General Public License v3.0
28 stars 7 forks source link

Closes Issues #9 (Suggestion: Add option to download captions only) and #13 (Some videos missing captions) #12

Closed BradMJustice closed 10 months ago

BradMJustice commented 10 months ago

First, we've addressed #9

Adds support for a new flag, --captions-only or -co. If set, video download will be skipped and only captions will be downloaded.

Next, #13 was addressed. The issue states that there are multiple possibilities of values that can exist in the config data when trying to parse out the caption URL. In episode::get_captions_url(), I've added a vector with all start possibilities, and a vector with all end possibilities. We now iterate through all possible combinations until a match is found. In my personal testing (primarily with season input https://www.dropout.tv/dimension-20/season:3 and series input https://www.dropout.tv/total-forgiveness), this change resulted in a 100% success rate in subtitle downloads. I'm going to run larger tests on shows with more episodes, and I encourage others to as well, but I think we're gucci here.

It's been 15 years since I've worked in C++ so I welcome any feedback. I also was not sure how to update and run the tests since I was only able to get the app working in Docker, but in Docker it does appear to be working.