most-inesctec / I2Bplus-tree

:evergreen_tree: Improved Interval B+ tree implementation, in TS :evergreen_tree:
https://www.npmjs.com/package/i2bplustree
MIT License
6 stars 0 forks source link

Fix `equals` method not allowing override #5

Open EdgarACarneiro opened 3 years ago

EdgarACarneiro commented 3 years ago

The current implementation does not allow the overriding of the FlatInterval.equals method since internally some FlatInterval objects are created to optimise data handling. As such, if one does override the equals method with the new properties, the search method brakes.

Possible solutions:

Nikovic commented 1 year ago

Hello. Is this bug/missing feature still around? I'm a little confused because overwriting equals is currently shown in the usage notes of the readme. If the bug is still around, a note in the readme might be a good idea.

I will be using I2Bplus-tree for a programming project in the context of my bachelor's thesis, and I'm open to contributing. Introducing the intervalEquals method seems like a good + fairly easy fix.

EdgarACarneiro commented 1 year ago

Hey @Nikovic thanks for your question - I need to take a deeper look into it since it has been a while I'll get back to you once I do so