Android AppCompat Beta 1.4.0-beta01 Release Breaks Builds

[AdlerJS]

The following line <framework src="androidx.appcompat:appcompat:+" /> in the plugin.xml file is now breaking Android Builds for SDKCompile versions less than 31 which is what I imagine all Capacitor projects are running with.

With the release of the new 1.4.0-beta01 : https://developer.android.com/jetpack/androidx/releases/appcompat which happened yesterday all builds using this plugin with SDK less than 31 will now break.

I would recommended instead of using + we just lock the version to 1.3.1 as this is the most recent stable version per the site. Let me know your thoughts and I can open a PR if need be. I've fixed it in our build pipeline for now by hacking around it but wouldn't mind solving it at the core for others using the plugin / having the same issue.

Thanks for the great plugin!

[mostafa-mansour1]

Thank you for your contribution If you think this will fix the issue Kindly open pull request and i will merge it Thank you

Regards,

---

Mostafa Mansour Software Engineer 00971 524988466

On 30 Sep 2021, at 10:05 PM, Dan Adler @.***> wrote:



The following line in the plugin.xml file is now breaking Android Builds for SDKCompile versions less than 31 which is what I imagine all Capacitor projects are running with.

With the release of the new 1.4.0-beta01 : https://developer.android.com/jetpack/androidx/releases/appcompat which happened yesterday all builds using this plugin with SDK less than 31 will now break.

I would recommended instead of using + we just lock the version to 1.3.1 as this is the most recent stable version per the site. Let me know your thoughts and I can open a PR if need be. I've fixed it in our build pipeline for now by hacking around it but wouldn't mind solving it at the core for others using the plugin / having the same issue.

Thanks for the great plugin!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/mostafa-mansour1/previewAnyFile/issues/37, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSFOB4LX47AD7SGXTFAPH3UESRIJANCNFSM5FC5AULQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[camhungh]

Hi @danbunkr , @mostafa-mansour1 , I'm still stuck with this issue and I also waiting the new version to fix it. I have made a PR. Could you review and merge it.

Thank you so much.

[pomma89]

@mostafa-mansour1, could you push the fixed version to NPM? Thank you very much!

[mostafa-mansour1]

Done