search

mostafa-mansour1 / previewAnyFile

Cordova Plugin to preview any file in native mode by providing the local or external URL
MIT License
33 stars 31 forks source link

`cordova-plugin-androidx` dependency #44

Open chvonrohr opened 2 years ago

chvonrohr commented 2 years ago

Ionic suggests to remove cordova-plugin-androidx and cordova-plugin-androidx-adapter plugins. See output of official Ionic Vscode plugin:

The plugin cordova-plugin-androidx is not required with Capacitor. This was required for Cordova Android 10 support but isnt required by Capacitor

Only plugin in our project which depends on them is now cordova-plugin-preview-any-file. Is this needed for Cordova projects compatibility?

mostafa-mansour1 commented 2 years ago

Dear

It need a test on cordova project to check if it’s required their or no

Regards,

Mostafa Mansour Software Engineer 00971 524988466

On 11 May 2022, at 4:32 PM, Christian von Rohr @.***> wrote:



Ionic suggests to remove cordova-plugin-androidx and cordova-plugin-androidx-adapter plugins. See output of official Ionic Vscode plugin:

The plugin cordova-plugin-androidx is not required with Capacitor. This was required for Cordova Android 10 support but isnt required by Capacitor

Only plugin which depends on them is now cordova-plugin-preview-any-file. Any reason, why those dependencies are still there?

— Reply to this email directly, view it on GitHubhttps://github.com/mostafa-mansour1/previewAnyFile/issues/44, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSFOBYPLTOA73L5RI67W2LVJOSGBANCNFSM5VUY23ZQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>