search

mostafa / xk6-kafka

k6 extension to load test Apache Kafka with support for various serialization formats, SASL, TLS, compression, Schema Registry client and beyond
Apache License 2.0
154 stars 69 forks source link

Implement Protocol Buffer serdes #71

Open mostafa opened 2 years ago

mostafa commented 2 years ago

Related:

Note to self: For implementing protobuf, I should use jhump/protoreflect, which internally uses yoheimuta/go-protoparser. The sample code is in the gRPC client of k6. The protobuf-dynamic Java library could be an inspiration.

lsolovey commented 2 years ago

Hi @mostafa - just wondering if you plan to address this issue anytime soon? Support for protobuf would be a great addition to Kafka xk6.

mostafa commented 2 years ago

@lsolovey I tried implementing it once, but it is more complicated than it looks, but I'll probably do it as some point, given enough upvotes. I'd be happy to see contributions, though. 😄

nrellanti commented 2 years ago

@mostafa, I'm looking help on protobuf. Do you have any latest code on this to share? Thanks In advance!

mostafa commented 2 years ago

@nrellanti Do you want to help develop it? If so, the links I mentioned here are the starting point. You need to build something like avro.go that extends the Serdes interface.

nrellanti commented 2 years ago

@mostafa , looking something like proto.go scripts from you in the scripts folder. If you have protobuf code, I will help testing the code in local.

mostafa commented 2 years ago

@nrellanti Thanks for offering help with testing, but the feature itself is not implemented yet.

bakha-talabat commented 1 year ago

@mostafa Wondering if the protobuf implementation is still in progress?

mostafa commented 1 year ago

Hey @bakha-talabat,

There has been no progress on this so far. I'd be happy to see your contributions, though.